[TEST] Remove Ord from PlaceRef #93315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data structure previously used here required Ord. As part of rust-lang#90317, we do not want DefId to implement Ord.
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
petrochenkov
added
S-waiting-on-author
pierwill
force-pushed
the
another-defid-branch
branch
from
35c3d68 to
a9a3f0b
Compare
pierwill
force-pushed
the
another-defid-branch
branch
from
a9a3f0b to
7630680
Compare
Aaron1011
added a commit
to Aaron1011/rust
that referenced
this pull request
May 10, 2022
This fixes rust-lang#96449, but I haven't yet been able to make the reproducer work using `#[cfg]` attributes, so we can't use the 'revision' infra to write a test The previous implementation relied on sorting by `PlaceRef`. This requires sorting by a `DefId`, which uses untracked state (see rust-lang#93315)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2022
…ochenkov Use `FxIndexSet` to avoid sorting fake borrows This fixes rust-lang#96449, but I haven't yet been able to make the reproducer work using `#[cfg]` attributes, so we can't use the 'revision' infra to write a test The previous implementation relied on sorting by `PlaceRef`. This requires sorting by a `DefId`, which uses untracked state (see rust-lang#93315)
Aaron1011
added a commit
to Aaron1011/rust
that referenced
this pull request
May 11, 2022
This is a new attempt at rust-lang#93315. It removes one usage of the `Ord` impl for `DefId`, which should make it easier to eventually remove that impl.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 12, 2022
…r-errors Remove `PartialOrd`/`Ord` impl for `PlaceRef` This is a new attempt at rust-lang#93315. It removes one usage of the `Ord` impl for `DefId`, which should make it easier to eventually remove that impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of work on #90317.
OrdforPlaceRefultimately depends onDefIdbeingOrd.