Skip to content

Even more let_else adoptions #94011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Even more let_else adoptions #94011

merged 1 commit into from
Feb 18, 2022

Conversation

est31
Copy link
Member

@est31 est31 commented Feb 15, 2022

Continuation of #89933, #91018, #91481, #93046, #93590.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 15, 2022
@rust-highfive
Copy link
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2022
@est31
Copy link
Member Author

est31 commented Feb 15, 2022

In the wake of #93951 I wanted to increase the amount let else is tested in the compiler, so I wrote a clippy lint to identify even more places that could benefit from using let else. I didn't find any issues with the let else feature, although I found some false positives for my lint, so this exercise was helpful :).

Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, after that r=me

@joshtriplett
Copy link
Member

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Feb 17, 2022

📌 Commit 60f969a has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2022
@bors bors merged commit 637d8b8 into rust-lang:master Feb 18, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants