-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Imrpove E0617 #94637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imrpove E0617 #94637
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
|
This comment has been minimized.
This comment has been minimized.
compiler/rustc_typeck/src/structured_errors/missing_cast_for_variadic_arg.rs
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
The job Click to see the possible cause of the failure (guessed by this bot)
|
@HTG-YT I notice you have closed your PR, so I will remove the label that it is waiting for review. Just to clear things up, reviews can take a bit ot time (also, the reviewer was choosen by the @rustbot and we didn't circle back on this quick enough to pick a reviewer). Anyway, contributions are all in on our radar, it just may take some time. In case you want to open this pull request again (or open another one), please feel to do so. Thanks! @rustbot label -S-waiting-on-review |
This Pull Request improves the error message for E0617 when dealing with the difference between
fn
types andfn
pointers.The current implementation causes all other error messages that utilize the
Display
representation ofTy
to show{individual function type for <function path>}
, if the type is a function item, and hence needs further discussion whether to make such change.We could only change such
Display
implementation if we're dealing withfn
types andfn
pointers and variadics.(Possibly) closes #69232