Skip to content

Report opaque type mismatches directly during borrowck of the function instead of within the type_of query. #95767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2022
Merged

Report opaque type mismatches directly during borrowck of the function instead of within the type_of query. #95767

merged 2 commits into from
Apr 7, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 7, 2022

This allows us to only store a single hidden type per opaque type instead of having to store one per set of substitutions.

r? @compiler-errors

This does not affect diagnostics, because the diagnostic messages are exactly the same.

@oli-obk
Report opaque type mismatches directly during borrowck of the functio…
25876b3 
…n instead of within the `type_of` query.

This allows us to only store a single hidden type per opaque type instead of having to store one per set of substitutions.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 7, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2022
@oli-obk oli-obk added the A-diagnostics Area: Messages for errors, warnings, and lints label Apr 7, 2022
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 7, 2022

📌 Commit 7d2cad6 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 7, 2022

@bors rollup=never

@oli-obk oli-obk mentioned this pull request Apr 7, 2022
Closed
@bors
Copy link
Collaborator

bors commented Apr 7, 2022

⌛ Testing commit 7d2cad6 with merge e745b4d...

@bors
Copy link
Collaborator

bors commented Apr 7, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing e745b4d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 7, 2022
@bors bors merged commit e745b4d into rust-lang:master Apr 7, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 7, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e745b4d): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: mixed results
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 8 2 9 2
mean2 N/A 0.4% -0.4% -0.8% -0.4%
max N/A 0.6% -0.4% -1.2% -0.4%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-diagnostics Area: Messages for errors, warnings, and lints merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @compiler-errors @bors @rust-timer @rust-highfive @rustbot