Ensure existance of dist directory when creating tarball #96207
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ It does seem like an odd difference, but probably not worth investigating at this time. |
|
📌 Commit b914678 has been approved by |
bors
added
S-waiting-on-bors
| @@ -262,11 +262,13 @@ impl<'a> Tarball<'a> { | |||
| t!(std::fs::rename(&self.image_dir, &dest)); | |||
|
|
|||
| self.run(|this, cmd| { | |||
| let distdir = crate::dist::distdir(this.builder); | |||
| t!(std::fs::create_dir_all(&distdir)); | |||
There was a problem hiding this comment.
Can we move this to fn distdir rather than special-casing it here? I'm worried we'll see this issue in other commands as well.
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (8d68f2f): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
|
This seems to be another possible case of the @rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
I'm not sure why this works in CI, but this is necessary to make distcheck (including the
x86_64-linux-distcheckimage) run on Fedora 35.