Register new snapshots #9771
Closed
Register new snapshots #9771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Oct 8, 2013
Still building locally, we'll see if anything dies...
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 1, 2022
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 1, 2022
Fix rust-lang#9771 (`unnecessary_to_owned` false positive) Fixes rust-lang#9771 In that issue's example(s), the lint tried to add a `&` to a value, which implicitly changed the type of a field to a reference. The fix is to add the reference to `receiver_ty` (the type of the receiver of the `to_owned`-like method), before passing `receiver_ty` to `can_change_type`. `can_change_type` properly rejects the modified `receiver_ty`. cc: `@mikerite` just because I think he was the author of `can_change_type`. changelog: fix `unnecessary_to_owned` false positive which implicitly tried to change the type of a field to a reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still building locally, we'll see if anything dies...