Skip to content

Make some lints incremental. #98238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2022
Merged

Make some lints incremental. #98238

merged 3 commits into from
Jun 19, 2022

Conversation

cjgillot
Copy link
Contributor

Those lints do not track a state, so don't need to be performed for the full crate at once.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 18, 2022
@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2022
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 18, 2022
@bors
Copy link
Collaborator

bors commented Jun 18, 2022

⌛ Trying commit a26f2a64f5538410ba093a29cd8d3483b18c3d70 with merge a9137293e51ca7eef6ad3eab77c18a1def11d3f9...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 18, 2022

☀️ Try build successful - checks-actions
Build commit: a9137293e51ca7eef6ad3eab77c18a1def11d3f9 (a9137293e51ca7eef6ad3eab77c18a1def11d3f9)

@rust-timer
Copy link
Collaborator

Queued a9137293e51ca7eef6ad3eab77c18a1def11d3f9 with parent ec21d7e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a9137293e51ca7eef6ad3eab77c18a1def11d3f9): comparison url.

Instruction count

  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 1.3% 3.4% 5
Regressions 😿
(secondary)		 50.6% 50.6% 1
Improvements 🎉
(primary)		 -0.4% -1.7% 48
Improvements 🎉
(secondary)		 -6.6% -90.8% 17
All 😿🎉 (primary) -0.3% 3.4% 53

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 7.0% 13.6% 4
Improvements 🎉
(primary)		 -2.0% -2.7% 9
Improvements 🎉
(secondary)		 -18.3% -76.9% 5
All 😿🎉 (primary) -2.0% -2.7% 9

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 4.9% 4.9% 1
Regressions 😿
(secondary)		 60.9% 60.9% 1
Improvements 🎉
(primary)		 -2.1% -2.7% 3
Improvements 🎉
(secondary)		 -23.2% -86.5% 5
All 😿🎉 (primary) -0.4% 4.9% 4

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 18, 2022
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 19, 2022
@bors
Copy link
Collaborator

bors commented Jun 19, 2022

⌛ Trying commit 1e7ec94 with merge e025df7b3bb4a0d516ef78fa4139d0690a291866...

@bors
Copy link
Collaborator

bors commented Jun 19, 2022

☀️ Try build successful - checks-actions
Build commit: e025df7b3bb4a0d516ef78fa4139d0690a291866 (e025df7b3bb4a0d516ef78fa4139d0690a291866)

@rust-timer
Copy link
Collaborator

Queued e025df7b3bb4a0d516ef78fa4139d0690a291866 with parent 6c9be6e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e025df7b3bb4a0d516ef78fa4139d0690a291866): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 0.3% 0.4% 2
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.4% -1.6% 40
Improvements 🎉
(secondary)		 -7.4% -90.8% 17
All 😿🎉 (primary) -0.4% -1.6% 42

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.2% 4.0% 3
Improvements 🎉
(primary)		 -1.9% -2.9% 10
Improvements 🎉
(secondary)		 -12.3% -76.9% 9
All 😿🎉 (primary) -1.9% -2.9% 10

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.4% -3.2% 3
Improvements 🎉
(secondary)		 -26.3% -86.3% 5
All 😿🎉 (primary) -2.4% -3.2% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Jun 19, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Jun 19, 2022

That's some nice wins

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 19, 2022

📌 Commit 1e7ec94 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2022
@bors
Copy link
Collaborator

bors commented Jun 19, 2022

⌛ Testing commit 1e7ec94 with merge 67404f7...

@bors
Copy link
Collaborator

bors commented Jun 19, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 67404f7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 19, 2022
@bors bors merged commit 67404f7 into rust-lang:master Jun 19, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 19, 2022
@bors bors mentioned this pull request Jun 19, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (67404f7): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.4% -1.7% 54
Improvements 🎉
(secondary)		 -7.4% -90.8% 17
All 😿🎉 (primary) -0.4% -1.7% 54

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.3% 2.3% 1
Improvements 🎉
(primary)		 -2.1% -3.0% 12
Improvements 🎉
(secondary)		 -13.8% -77.0% 8
All 😿🎉 (primary) -2.1% -3.0% 12

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.4% -3.3% 3
Improvements 🎉
(secondary)		 -25.9% -86.4% 5
All 😿🎉 (primary) -2.4% -3.3% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@cjgillot cjgillot deleted the lint-mod branch June 22, 2022 20:14
RalfJung
RalfJung reviewed Nov 12, 2022
View reviewed changes
compiler/rustc_middle/src/mir/interpret/queries.rs
impl<'tcx> TyCtxtEnsure<'tcx> {
/// Evaluates a constant without providing any substitutions. This is useful to evaluate consts
/// that can't take any generic arguments like statics, const items or enum discriminants. If a
/// generic parameter is used within the constant `ErrorHandled::ToGeneric` will be returned.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments (also the one below) are wrong now -- they talk about the return value of a function that doesn't return anything! I have no idea what is going on here so if someone could make a PR to update the comments, that would be much appreciated. :)

@cjgillot cjgillot mentioned this pull request Nov 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
8 participants
@cjgillot @rust-highfive @rust-timer @bors @rust-log-analyzer @oli-obk @RalfJung @rustbot