Skip to content

New tykind::error convention #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

New tykind::error convention #715

merged 1 commit into from
Jun 19, 2020

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m mentioned this pull request May 26, 2020
Merged
@LeSeulArtichaut LeSeulArtichaut added the S-blocked Status: this PR is blocked waiting for something label May 26, 2020
@mark-i-m mark-i-m removed the S-blocked Status: this PR is blocked waiting for something label Jun 17, 2020
@mark-i-m
Copy link
Member Author

We can merge this soon as rust-lang/rust#70551 is in the bors queue...

@mark-i-m
Copy link
Member Author

This is ready to merge. Can someone review and approve please?

LeSeulArtichaut
LeSeulArtichaut approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeSeulArtichaut LeSeulArtichaut merged commit 45e540c into rust-lang:master Jun 19, 2020
@mark-i-m mark-i-m deleted the ty-err branch June 27, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mark-i-m @LeSeulArtichaut