-
Notifications
You must be signed in to change notification settings - Fork 153
Update clap to 4.5.36 #2073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update clap to 4.5.36 #2073
Conversation
- **clap-3.1.6**: A command line argument parser library. A crate used by many | ||
Rust programs. | ||
- **clap-3.1.6**: A command line argument parser library. A crate used by many Rust programs. | ||
- **clap-4.5.36**: A command line argument parser library. A crate used by many Rust programs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should be updated to explain that it's just the proc macro part.
I think this benchmark should be renamed from |
That idea also crossed my mind, although the I would still keep the workspace selection logic in rustc-perf, it's quite useful for local benchmarking when you want to benchmark a workspace crate that is not in the main benchmark suite. |
This PR updates the
clap
benchmark to4.5.36
. Clap is now just a workspace where the root crate only contains documentation, so I benchmark theclap_derive
crate, which has no local dependencies, so rustc-perf can deal with it. I added support for selecting a workspace package to rustc-perf to support this, that was easy enough.clap_derive
is a proc-macro, we don't have that many of these in the benchmark suite.Related issue: #2024