Support and stabilize inline asm on all platforms #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LLVM backend is generally available, while the gnu assembler is not on Windows and many other platforms by default.
bjorn3
force-pushed
the
use_llvm_backend_as_assembler
branch
from
1ada9ad to
20e4436
Compare
But exclude sym operands for now as they are somewhat broken.
bjorn3
force-pushed
the
use_llvm_backend_as_assembler
branch
from
20e4436 to
35453ac
Compare
bjorn3
force-pushed
the
use_llvm_backend_as_assembler
branch
from
8b24434 to
69c6aa5
Compare
bjorn3
added a commit
that referenced
this pull request
Oct 30, 2023
#1403 extended support to all targets supported by cg_clif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Windows compatibility we now use the LLVM backend of rustc as "external assembler".
I discovered that more crates than I initially expected already depend on inline asm for at least x86. This includes Bevy through one of its dependencies.
Part of #1204