Revert run-make/const_fn_mir ignore #1497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jun 17, 2024
| @@ -127,7 +125,6 @@ rm -r tests/run-make/panic-abort-eh_frame # .eh_frame emitted with panic=abort | |||
| # bugs in the test suite | |||
| # ====================== | |||
| rm tests/ui/process/nofile-limit.rs # TODO some AArch64 linking issue | |||
| rm -r tests/run-make/const_fn_mir # needs-unwind directive accidentally dropped | |||
There was a problem hiding this comment.
Only this change should be reverted. The rest is unrelated to the issue rust-lang/rust#126580 fixes.
GuillaumeGomez
force-pushed
the
revert-fix
branch
from
f12714f to
1657c64
Compare
|
Ah I see, makes more sense. Removed the other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit e241176.
Can be merged once rust-lang/rust#126580 is merged.