Skip to content

New line inserted between ) and { in ClosingNextLine mode when line length is 99 #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copy opened this issue Aug 29, 2018 · 0 comments · Fixed by #4246
Closed

New line inserted between ) and { in ClosingNextLine mode when line length is 99 #2978

copy opened this issue Aug 29, 2018 · 0 comments · Fixed by #4246
Labels
only-with-option requires a non-default option value to reproduce poor-formatting

Comments

@copy
Copy link

copy commented Aug 29, 2018

rustfmt formats inserts a newline between ) and { in this example:

pub fn test() {
    let xxxxxxxxxxxxxxxxxxxxxxxxxxxx = yyyyyyyyyyyyyyyy | zzzzzzzzzzzzzzzzzzzzzzzz | if for_writing
    {
        fffffffffffffffffffff
    }
    else {
        g
    };
}

When the let xxx… line has 99 characters.

I would expect a formatting like this (which rustfmt produces when adding one more x):

pub fn test() {
    let xxxxxxxxxxxxxxxxxxxxxxxxxxxxx =
        yyyyyyyyyyyyyyyy | zzzzzzzzzzzzzzzzzzzzzzzz | if for_writing {
            fffffffffffffffffffff
        }
        else {
            g
        };
}
@nrc nrc added this to the 1.0 (edition rc1) milestone Sep 4, 2018
@nrc nrc removed this from the 1.0 (edition rc1) milestone Sep 19, 2018
@nrc nrc added only-with-option requires a non-default option value to reproduce and removed p-medium labels Sep 19, 2018
ayazhafiz added a commit to ayazhafiz/rustfmt that referenced this issue Jun 8, 2020
Adds regression tests for the following issues which seem to be fixed on
master:

Closes rust-lang#1762
Closes rust-lang#2201
Closes rust-lang#2388
Closes rust-lang#2672
Closes rust-lang#2755
Closes rust-lang#2947
Closes rust-lang#2978
Closes rust-lang#3148
Closes rust-lang#3206

@topecongiro @calebcartwright appologies for the large number of issues
in this commit; if you prefer I can split it up into 2+.
ayazhafiz added a commit to ayazhafiz/rustfmt that referenced this issue Jun 9, 2020
Adds regression tests for the following issues which seem to be fixed on
master:

Closes rust-lang#1762
Closes rust-lang#2388
Closes rust-lang#2672
Closes rust-lang#2755
Closes rust-lang#2947
Closes rust-lang#2978
Closes rust-lang#3148
Closes rust-lang#3206

@topecongiro @calebcartwright appologies for the large number of issues
in this commit; if you prefer I can split it up into 2+.
calebcartwright pushed a commit that referenced this issue Jun 9, 2020
* Prune stale issues

Adds regression tests for the following issues which seem to be fixed on
master:

Closes #1762
Closes #2388
Closes #2672
Closes #2755
Closes #2947
Closes #2978
Closes #3148
Closes #3206

@topecongiro @calebcartwright appologies for the large number of issues
in this commit; if you prefer I can split it up into 2+.

* fixup! Prune stale issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
only-with-option requires a non-default option value to reproduce poor-formatting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants