Skip to content

2.0.0-rc.2 formatting regression with line-wrapped functions #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahl opened this issue Aug 6, 2020 · 0 comments · Fixed by #4368
Closed

2.0.0-rc.2 formatting regression with line-wrapped functions #4366

ahl opened this issue Aug 6, 2020 · 0 comments · Fixed by #4368
Assignees
@topecongiro
Labels
poor-formatting
Milestone
2.0.0

Comments

@ahl
Copy link
Contributor

ahl commented Aug 6, 2020

Input

// rustfmt-max_width: 80
trait GetMetadata {
    fn metadata(loc: ApiEndpointParameterLocation)
        -> Vec<ApiEndpointParameter>;
}

Output

// rustfmt-max_width: 80
trait GetMetadata {
    fn metadata(loc: ApiEndpointParameterLocation)
    -> Vec<ApiEndpointParameter>;
}

Expected output

// rustfmt-max_width: 80
trait GetMetadata {
    fn metadata(loc: ApiEndpointParameterLocation)
        -> Vec<ApiEndpointParameter>;
}

Meta

  • rustfmt version: rustfmt 2.0.0-rc.2-nightly (0921e1f 2020-07-29)
  • From where did you install rustfmt?: built from source
@ahl ahl changed the title 2.0.0-rc.2 formatting regression 2.0.0-rc.2 formatting regression with line-wrapped functions Aug 6, 2020
@ahl ahl mentioned this issue Aug 6, 2020
Closed
ayazhafiz added a commit to ayazhafiz/rustfmt that referenced this issue Aug 6, 2020
@ayazhafiz
Indent return types separated from params by newline
238fcd4 
 rust-lang#3891 removed Version One formatting that did this correctly (https://github.com/rust-lang/rustfmt/pull/3891/files#diff-5db152a52bdaeae9dacd35f43a4a78ddL2342-L2344),
but at seemingly at the time there were no tests to catch the
regression.

This commit fix-forwards the formatting regression, though via a different
implementation because the original implementation would muddle the branch
for visual indentation and this fix, which is probably not preferrable
giving the existing complexity of the rewrite_required_fn method.

Closes rust-lang#4366
ayazhafiz added a commit to ayazhafiz/rustfmt that referenced this issue Aug 6, 2020
@ayazhafiz
Indent return types separated from params by newline
6e8dde3 
 rust-lang#3891 removed Version One formatting that did this correctly (https://github.com/rust-lang/rustfmt/pull/3891/files#diff-5db152a52bdaeae9dacd35f43a4a78ddL2342-L2344),
but at seemingly at the time there were no tests to catch the
regression.

This commit fix-forwards the formatting regression, though via a different
implementation because the original implementation would muddle the branch
for visual indentation and this fix, which is probably not preferrable
giving the existing complexity of the rewrite_required_fn method.

Closes rust-lang#4366
ayazhafiz added a commit to ayazhafiz/rustfmt that referenced this issue Aug 6, 2020
@ayazhafiz
Indent return types separated from params by newline
7247e8a 
 rust-lang#3891 removed Version One formatting that did this correctly (https://github.com/rust-lang/rustfmt/pull/3891/files#diff-5db152a52bdaeae9dacd35f43a4a78ddL2342-L2344),
but at seemingly at the time there were no tests to catch the
regression.

This commit fix-forwards the formatting regression, though via a different
implementation because the original implementation would muddle the branch
for visual indentation and this fix, which is probably not preferrable
giving the existing complexity of the rewrite_required_fn method.

Closes rust-lang#4366
@ayazhafiz ayazhafiz mentioned this issue Aug 6, 2020
Merged
@calebcartwright calebcartwright added this to the 2.0.0 milestone Aug 7, 2020
calebcartwright pushed a commit that referenced this issue Aug 7, 2020
@ayazhafiz
Indent return types separated from params by newline (#4368)
f817383 
* Indent return types separated from params by newline

 #3891 removed Version One formatting that did this correctly (https://github.com/rust-lang/rustfmt/pull/3891/files#diff-5db152a52bdaeae9dacd35f43a4a78ddL2342-L2344),
but at seemingly at the time there were no tests to catch the
regression.

This commit fix-forwards the formatting regression, though via a different
implementation because the original implementation would muddle the branch
for visual indentation and this fix, which is probably not preferrable
giving the existing complexity of the rewrite_required_fn method.

Closes #4366

* fixup! Indent return types separated from params by newline
ahl added a commit to oxidecomputer/dropshot that referenced this issue Aug 10, 2020
@ahl
with the fix for rust-lang/rustfmt#4366
95f4b0f
@topecongiro topecongiro mentioned this issue Sep 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topecongiro topecongiro

Labels
poor-formatting
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Indent return types separated from params by newline ayazhafiz/rustfmt
3 participants
@ahl @calebcartwright @topecongiro