-
Notifications
You must be signed in to change notification settings - Fork 924
Use semver
to check required_version
instead of comparing two strings with !=
#6063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I suppose there is also could be point like "produce correct semver-value for generated config" and should be decided what it should be - exact strict with =, or range or just ^. |
My preferred path would be, if
But as currently the |
Agree totally, but not sure how this would differentiate from typing |
@ologbonowiwi you can run
Agreed. Deciding that can likely wait till later. |
#6066 addressing it. Needed to change the behavior as Please let me know if you have any thoughts/feedbacks on the PR. And thanks for the opportunity of contributing to this fantastic project 😄 |
…n' of github.com:ologbonowiwi/rustfmt into feat/rust-lang#6063/use-semver-to-check-required-version
…n' of github.com:ologbonowiwi/rustfmt into feat/rust-lang#6063/use-semver-to-check-required-version
…lang#6063/use-semver-to-check-required-version
…n' of github.com:ologbonowiwi/rustfmt into feat/rust-lang#6063/use-semver-to-check-required-version
My plan is to use semver library to achieve so.
The idea is to change
rustfmt/src/config/mod.rs
Line 217 in 041f113
including the comparison tools provided by
semver
.This will allow complex comparisons such as
instead of only plain files.
I'm willing to work on it, btw.
Opening it as an effort to contribute to turning
required_version
into a stable flag.The text was updated successfully, but these errors were encountered: