Skip to content

test cargo fmt --all -- --check returns success after formatting #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2018

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Jun 15, 2018

Adds test for the failure in #2787 , doesn't fix anything.

@nrc
Copy link
Member

nrc commented Jun 18, 2018

Looks good thanks, but as expected, we now fail testing for stdsimd, so could you move that to the expect to fail list please?

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Jun 18, 2018

Yes, sorry, I was just checking why on failure travis was still reporting success (it seems like $0 in the ifs was reporting the exit code of tee which is always success... my bad...).

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Jun 18, 2018

I've tried to fix chalk by making it build, but it seems that it lacks permissions to generate the files on CI for whatever reason. I think that to make chalk pass fixing #2789 is probably a better way forward.

The build here should be green otherwise.

@nrc nrc merged commit 75d46b1 into rust-lang:master Jun 18, 2018
@nrc
Copy link
Member

nrc commented Jun 18, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants