Skip to content

Use the correct shape when formatting comment in empty struct #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2020
Merged

Use the correct shape when formatting comment in empty struct #4058

merged 1 commit into from
Feb 18, 2020

Conversation

topecongiro
Copy link
Contributor

Close #4014.

@calebcartwright
Copy link
Member

Does this solve #3937 too by any chance?

@topecongiro
Copy link
Contributor Author

@calebcartwright This PR fixes the first issue described in the first example in #3937 but not the second one.

@topecongiro topecongiro merged commit 4488e40 into rust-lang:master Feb 18, 2020
@topecongiro topecongiro deleted the issue-4014 branch February 18, 2020 12:23
@ytmimi
Copy link
Contributor

ytmimi commented Mar 31, 2022 •
edited
Loading

#5171 unintentionally backported the correct shape fix, so this backport is complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
1x-backport:completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indentation is broken for multiple line comments inside struct
4 participants
@topecongiro @calebcartwright @ytmimi @karyon