Pick up comments before where clause in traits #4213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
changed the title
| @@ -0,0 +1,13 @@ | |||
| trait SomeTrait<T> | |||
There was a problem hiding this comment.
In a case like this that's an idempotence check the file under source can be omitted.
calebcartwright
approved these changes
May 31, 2020
There was a problem hiding this comment.
LGTM thanks!
One inline comment about the file under source being unnecessary in the current state. Not a big deal, but it could either be removed or modified (for example moving the comments around to ensure they're formatted correctly when placed between the generic and where clause spans)
|
Thanks for pointing that out; I had them with differing contents in a previous version and didn't clean it up. Should be fixed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4211