Skip to content

try to write the parameter on a new line in case the attribute/parameter together are over max_width #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Oct 6, 2020

Close #4059

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calebcartwright
Copy link
Member

Well hello there @scampi 👋

@scampi
Copy link
Contributor Author

scampi commented Oct 6, 2020

For PRs resolving hacktoberfest issues, we need to add the tag: See message below

Ineligible Repository

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

Do you want me to update other PRs accordingly ?

@calebcartwright
Copy link
Member

I didn't realize adding it as a repo topic was required this year, but yeah, let's add the accepted labels (unless you have access to update the topics, as i don't)

@scampi scampi merged commit 04705fe into master Oct 9, 2020
@scampi scampi deleted the issue-4059.rs branch October 9, 2020 01:40
@karyon
Copy link
Contributor

karyon commented Oct 27, 2021

backported in #4980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiline long params with attributes
3 participants