Skip to content

[Backport] Option to create groups for imports #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

[Backport] Option to create groups for imports #4531

merged 1 commit into from
Nov 19, 2020

Conversation

MattX
Copy link
Contributor

@MattX MattX commented Nov 17, 2020

Backport of 17d90ca (see #4445)

@MattX MattX changed the title Option to create groups for std, external crates, and other imports [Backport] Option to create groups for imports Nov 17, 2020
@calebcartwright calebcartwright changed the base branch from rustfmt-1.4.27 to rustfmt-1.4.28 November 17, 2020 00:24
calebcartwright
calebcartwright approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Going to be cutting a new release to get a bug fix out, so this will get pulled in as well 👍

@calebcartwright calebcartwright merged commit 073cc38 into rust-lang:rustfmt-1.4.28 Nov 19, 2020
@strohel
Copy link

strohel commented Nov 20, 2020

So cool this is merged. Shouldn't it get a CHANGELOG entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
pr-not-reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattX @strohel @calebcartwright