Skip to content

Backport "Link tracking issues in Configurations.md" #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

karyon
Copy link
Contributor

@karyon karyon commented Oct 28, 2021

This backports

with a few merge conflicts fixed.

@karyon karyon changed the title Link tracking issues in Configurations.md (#4096) Backport "Link tracking issues in Configurations.md" Oct 28, 2021
@ytmimi
Copy link
Contributor

ytmimi commented Nov 5, 2021

This PR looks good to me! Simple enough change to add links to various issue numbers in Configurations.md!

@calebcartwright
Copy link
Member

Thank you @karyon for the PR and @ytmimi for taking a look!

One thing I was a bit hesitant about with backporting the original PR was whether any of the "stabilized" issues on the other branch are ones we haven't actually stabilized yet, and whether there was any risk of speciously indicating an option was stabilized in the docs, as well as whether there were any we'd subsequently stabilized.

However, I imagine those would've been the types of things that caused the aforementioned merge conflicts, and were already resolved?

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@calebcartwright calebcartwright merged commit e6d1bf5 into rust-lang:master Nov 9, 2021
@karyon
Copy link
Contributor Author

karyon commented Nov 9, 2021 via email

@karyon karyon deleted the backport-link-tracking-issues branch November 14, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants