-
Notifications
You must be signed in to change notification settings - Fork 925
feat: use semver
to match required version
#6066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ytmimi
merged 48 commits into
rust-lang:master
from
wesleymatosdev:feat/#6063/use-semver-to-check-required-version
Feb 26, 2025
Merged
Changes from 8 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
3469dd6
test: add test for `required_version`
wesleymatosdev 2ce0666
chore: install `semver`
wesleymatosdev 01a1ebf
refactor: use `semver` to compare versions
wesleymatosdev 73e75ad
fix: use exact version for comparison when no comparator is specified
wesleymatosdev 75b65d6
refactor: avoid overhead by considering default behavior from `semver`
wesleymatosdev 33eb55c
test: add complex comparisons for required_version
wesleymatosdev b9934e6
refactor: handle `required_version` parsing manually
wesleymatosdev 21ca2e2
chore: add `#[allow(dead_code)]`
wesleymatosdev 435d1b9
docs: specify atual behavior on required_version docs
wesleymatosdev cbb6f62
refactor: avoid unwrap and nesting
wesleymatosdev 93a3400
refactor: extract semver version checking
wesleymatosdev 1fc86bc
test: extensively test `chek_semver_version`
wesleymatosdev 89d2c0b
Merge branch 'master' into feat/#6063/use-semver-to-check-required-ve…
wesleymatosdev 005ecb9
docs: add examples on configurations
wesleymatosdev d599275
Merge branch 'feat/#6063/use-semver-to-check-required-version' of git…
wesleymatosdev 012f71b
docs: explain multiple values
wesleymatosdev da749b6
docs: mention `semver::Version` spec
wesleymatosdev 18e692d
docs: delete `semver::Version` from spec
wesleymatosdev dd1d8ce
docs: add examples of different settings
wesleymatosdev cf53621
Merge branch 'feat/#6063/use-semver-to-check-required-version' of git…
wesleymatosdev 7a92ca5
feat: enforce exact comparison
wesleymatosdev a7a04c7
docs: add more examples of operators
wesleymatosdev aceb3fd
docs: improve formatting
wesleymatosdev 7fe12d1
refactor: early return `None` to avoid cognitive load
wesleymatosdev 9142de4
docs: add `*` to examples
wesleymatosdev 899d843
docs: clarify `*` restrictions on range
wesleymatosdev 5b6592d
Update Configurations.md
wesleymatosdev 60b7e2f
style(docs): add `:` to keep standard
wesleymatosdev ab0ba60
refactor: improve variable naming
wesleymatosdev f096df6
docs: add comment explaining why we need to check `^` and override th…
wesleymatosdev c3537ea
Merge branch 'master' into feat/#6063/use-semver-to-check-required-ve…
wesleymatosdev c29d067
refactor: use `version_req` instead of `required_version` and `label`…
wesleymatosdev aa2df65
test: add `"./rustfmt.toml"` to `Path`
wesleymatosdev 2b58939
test: add wildcard unmatch
wesleymatosdev 9380e25
docs: improve multiple versions to match session
wesleymatosdev 9c4682a
test: add test for invalid usage of `||`
wesleymatosdev 9567198
Merge branch 'master' of github.com:rust-lang/rustfmt into feat/#6063…
wesleymatosdev d649463
refactor: add versions on error logs
wesleymatosdev 82dbefd
test: include more tests for mismatching versions
wesleymatosdev fbaddcc
docs: remove confusing section
wesleymatosdev 0bae336
Merge branch 'feat/#6063/use-semver-to-check-required-version' of git…
wesleymatosdev 23cf487
docs: re-include `style_edition` deleted by merge
wesleymatosdev f5684a7
docs: improve contradicting requirements explanation
wesleymatosdev fede8d0
test: include more mismatch tests
wesleymatosdev 4e15dbf
docs: revert unnecessary change
wesleymatosdev e201040
test: include test matching to wildcard matching any version
wesleymatosdev afdef69
docs: improve multiple versions to match explanation
wesleymatosdev 1eacf2c
Merge branch 'master' into feat/#6063/use-semver-to-check-required-ve…
wesleymatosdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.