impl rewrite_result for ast::Expr #6311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ding-young
commented
Sep 2, 2024
Comment on lines
-370
to
-377
| macro_rules! skip_out_of_file_lines_range { | ||
| ($self:ident, $span:expr) => { | ||
| if out_of_file_lines_range!($self, $span) { | ||
| return None; | ||
| } | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Now this is totally replaced with skip_out_of_file_lines_range! which returns RewriteError::SkipFormatting instead of None
There was a problem hiding this comment.
You mean skip_out_of_file_lines_range_err? In a follow up PR I think it would be nice to rename skip_out_of_file_lines_range_err back to skip_out_of_file_lines_range! Now that we know we've replaced all the invocations to return RewriteResult. I'm not in a rush to make this change though.
41 tasks
ytmimi
approved these changes
Sep 5, 2024
ytmimi
force-pushed
the
rw-result-expr
branch
from
619a862 to
0ccb6b6
Compare
|
Running the Diff-Check Edit: Job passed ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracked by #6206
Description
This pr impl
rewrite_resultforExprby updatingformat_exprto returnRewriteResult.Now we don't call
.ok()after callingrewrite_***functions informat_expr:)