Skip to content

as_ref_mut.rs has two I AM NOT DONE #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
steelwil opened this issue Jan 2, 2020 · 4 comments
Closed

as_ref_mut.rs has two I AM NOT DONE #259

steelwil opened this issue Jan 2, 2020 · 4 comments

Comments

@steelwil
Copy link

steelwil commented Jan 2, 2020

No description provided.

@AbdouSeck
Copy link
Contributor

Hi @steelwil, thanks for reporting this. The idea behind the two I AM NOT DONE lines is to indicate that there are two separate tasks in the file to finish. If it seems too cumbersome, the second one can definitely disappear. Let me know what you think.

Thank you,

Abdou

@steelwil
Copy link
Author

steelwil commented Jan 7, 2020

I think keeping things consistent is important, writing a different exercise may be a better idea.

@AbdouSeck
Copy link
Contributor

Hi @steelwil, I don't think it's necessary to write a different exercise. I would be fine with removing the second "I AM NOT DONE" occurrence.

Tuxified added a commit to Tuxified/rustlings that referenced this issue Apr 7, 2020
@Tuxified
Remove duplicate not done comment
dab90f7 
As indicated in rust-lang#259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from rust-lang#281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
@Tuxified Tuxified mentioned this issue Apr 7, 2020
Merged
@Tuxified
Copy link
Contributor

👋 I think this issue can be closed as it has been changed by #292 ?

MendelMonteiro pushed a commit to MendelMonteiro/rustlings that referenced this issue Jun 28, 2020
@Tuxified @MendelMonteiro
Remove duplicate not done comment
4617450 
As indicated in rust-lang#259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from rust-lang#281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
Remove duplicate not done comment
de32a72 
As indicated in rust-lang#259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from rust-lang#281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@Tuxified
Remove duplicate not done comment
32d7f08 
As indicated in rust-lang#259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from rust-lang#281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Tuxified @steelwil @shadows-withal @AbdouSeck