Require fma
and f16c
for avx512f
in std_detect
#1781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target feature
avx512f
impliesavx2
,fma
andf16c
in rustc, but Intel only guarantees thatavx2
will be there whenavx512f
is present, nothing aboutfma
orf16c
. This is correct behavior by rustc, and is based on how the assembler decides what encoding to use, VEX vs EVEX. So this PR simply requires thatfma
andf16c
be present when enabling any AVX512 target features, to match exactly with rustc behavior.Related:
avx512dq
andavx512vl
implication foravx512fp16
rust#140002