-
Notifications
You must be signed in to change notification settings - Fork 0
pix regression: env is global after normalization impl shadowing #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Closed
Zalathar
added a commit
to Zalathar/rust
that referenced
this issue
May 8, 2025
…orm, r=lcnr Only prefer param-env candidates if they remain non-global after norm Introduce `CandidateSource::GlobalParamEnv`, and dynamically compute the `CandidateSource` based on whether the predicate contains params *post-normalization*. This code needs some cleanup and documentation. I'm just putting this up for review. cc rust-lang/trait-system-refactor-initiative#179 r? lcnr
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
May 8, 2025
…orm, r=lcnr Only prefer param-env candidates if they remain non-global after norm Introduce `CandidateSource::GlobalParamEnv`, and dynamically compute the `CandidateSource` based on whether the predicate contains params *post-normalization*. This code needs some cleanup and documentation. I'm just putting this up for review. cc rust-lang/trait-system-refactor-initiative#179 r? lcnr
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 8, 2025
Rollup merge of rust-lang#140260 - compiler-errors:only-global-post-norm, r=lcnr Only prefer param-env candidates if they remain non-global after norm Introduce `CandidateSource::GlobalParamEnv`, and dynamically compute the `CandidateSource` based on whether the predicate contains params *post-normalization*. This code needs some cleanup and documentation. I'm just putting this up for review. cc rust-lang/trait-system-refactor-initiative#179 r? lcnr
fixed by #140260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
https://crater-reports.s3.amazonaws.com/pr-133502-2/try%23da0a4799770027c4c578bf48cdb390acfde09023/reg/pix-0.14.0/log.txt
Minimized:
New solver sees
T::Item
in where clause, prefers that b/c it mentions params even though it can be normalized, and chooses theOldSolver: Into<NewSolver>
impl.Old solver normalizes param-env, so it sees
OldSolver: Into<NewSolver>
is global, and chooses the reflexiveT: Into<T>
impl.The text was updated successfully, but these errors were encountered: