Implement setting review assignment limit #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
setting-review-assignment-limit
branch
from
1ecaf84 to
2e3aa37
Compare
Urgau
reviewed
Apr 17, 2025
Kobzol
force-pushed
the
setting-review-assignment-limit
branch
from
2e3aa37 to
e8e7e33
Compare
Urgau
approved these changes
Apr 17, 2025
This was referenced Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the logic from #1854 and updates it to the updated DB schema. It also handles upsert of users into the DB, as we don't know in advance if they will be present there or not.
I renamed the command from
work settowork set-pr-limit, but I don't care much about the naming here. I also added an option to reset the limit to unlimited (NULL) usingwork set-pr-limit none.I don't think that we need a set of testing users here, as the limit is not taken into account when doing reviews yet. But it would be nice to have some data in the DB before we implement that (I plan to refactor PR assignment as a next step).
Best reviewed commit by commit.