aml: fix clippy warnings and run clippy in CI #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
00xc
commented
Dec 24, 2024
•
00xc
commented
- Fix several warnings so that clippy runs cleanly on the AML crate and its tests.
- Add clippy runs on the AML crate and its tests as part of CI.
- Add a missing clippy run on the ACPI crate tests.
Now that all warnings have been fixed for the aml crate, run clippy as part of CI. Once the warnings for the rest of the crates are fixed, they can be included in the CI run.
Now that all warnings have been fixed for the aml crate tests, run clippy as part of CI.
|
@IsaacWoods could you review this? All changes should be fairly trivial. Thanks! |
|
Apologies for the delay - all looks good. Thanks! |
IsaacWoods
pushed a commit
to IsaacWoods/acpi
that referenced
this pull request
Jan 30, 2025
* aml: fix all clippy warnings * ci: run clippy on aml crate Now that all warnings have been fixed for the aml crate, run clippy as part of CI. Once the warnings for the rest of the crates are fixed, they can be included in the CI run. * aml: tests: fix all clippy warnings * ci: run clippy on aml crate tests Now that all warnings have been fixed for the aml crate tests, run clippy as part of CI. * ci: run clippy on acpi crate tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.