Fix memory leaks in DevicePathFromText #1525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-dp-convert-free
branch
from
6b7aa05 to
385869a
Compare
phip1611
reviewed
Jan 24, 2025
phip1611
reviewed
Jan 24, 2025
nicholasbishop
force-pushed
the
bishop-dp-convert-free
branch
from
385869a to
d46a0a6
Compare
This is in preparation for adding a PoolDevicePath type, which will also use PoolAllocation.
The methods of both DevicePathToText and DevicePathFromText return memory that is allocated internally by UEFI, so it needs to be freed on drop. DevicePathToText already does that correctly by returning a `PoolString`, but this was missed in DevicePathFromText, which just returns a reference. Fix by adding PoolDevicePath and PoolDevicePathNode structs, and return them from the corresponding methods of DevicePathFromText.
nicholasbishop
force-pushed
the
bishop-dp-convert-free
branch
from
d46a0a6 to
65155fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods of both
DevicePathToTextandDevicePathFromTextreturn memory that is allocated internally by UEFI, so it needs to be freed on drop.DevicePathToTextalready does that correctly by returning aPoolString, but this was missed inDevicePathFromText, which just returns a reference.Fix by adding
PoolDevicePathandPoolDevicePathNodestructs, and return them from the corresponding methods ofDevicePathFromText.Also add an
PoolAllocationstruct to reduce code duplication. I've kept this type internal for now, as we might want to introduce a more generic pool allocation struct in the future so that we don't need separate type definitions forPoolString,PoolDevicePath,PoolDevicePathNode, etc. But that would take some more thought to get the API right, so for now these simple additions seem like the most straightforward fix.Checklist