Skip to content

Fix uefi-raw MSRV build, and improve CI for MSRV #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

nicholasbishop
Copy link
Member

uefi-raw has a lower MSRV than the uefi package, currently 1.70. Fix a minor error that prevented it from building at that MSRV, and add a job to check that package's MSRV build going forward.

Also improve the existing MSRV job so that it uses cargo to get the correct MSRV value, rather than having a separate MSRV toolchain file that has to be updated manually.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

`size_of` wasn't added to the prelude until 1.80, but the uefi-raw MSRV is
currently 1.70.
Delete msrv_toolchain.toml, and instead read the MSRV from cargo and copy it to
rust-toolchain.toml. This ensures the job is checking the same MSRV set in
Cargo.toml, and reduces the number of places that the MSRV needs to be manually
updated when we change it.
The `uefi-raw` package has a lower MSRV than the `uefi` package, so it needs to
be tested separately.
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phip1611 phip1611 added this pull request to the merge queue Feb 16, 2025
Merged via the queue into rust-osdev:main with commit e9e62eb Feb 16, 2025
16 checks passed
@nicholasbishop nicholasbishop deleted the bishop-test-raw-msrv branch February 16, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants