"is_regular_file" for file trait + integration test #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
is-file-is-directory
branch
2 times, most recently
from
88dbcc1 to
3018cfb
Compare
phip1611
changed the title
phip1611
commented
Jul 31, 2022
phip1611
force-pushed
the
is-file-is-directory
branch
from
147343c to
2c12656
Compare
phip1611
commented
Jul 31, 2022
|
Short notice: I'm currently on vacation and probably won't work on the PRs until the last week of August |
phip1611
force-pushed
the
is-file-is-directory
branch
from
2c12656 to
2bf06d5
Compare
|
This is ready for the next review round. |
phip1611
changed the title
phip1611
force-pushed
the
is-file-is-directory
branch
from
2bf06d5 to
8f009c0
Compare
nicholasbishop
requested changes
Sep 1, 2022
phip1611
force-pushed
the
is-file-is-directory
branch
from
8f009c0 to
83ade2e
Compare
phip1611
changed the title
phip1611
changed the title
phip1611
force-pushed
the
is-file-is-directory
branch
2 times, most recently
from
759588f to
e20ba60
Compare
phip1611
changed the title
phip1611
force-pushed
the
is-file-is-directory
branch
from
e20ba60 to
eb2659c
Compare
This is necessary as preparation for the integration test.
phip1611
force-pushed
the
is-file-is-directory
branch
from
eb2659c to
38d7eae
Compare
|
Ready for another review round @nicholasbishop |
phip1611
force-pushed
the
is-file-is-directory
branch
from
38d7eae to
f8bd537
Compare
phip1611
force-pushed
the
is-file-is-directory
branch
from
f8bd537 to
09b01a9
Compare
nicholasbishop
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds the "is_regular_file" and "is_regular_directory"-methods for the File-trait which is especially useful if you work with the generic
FileHandleabstraction.Furthermore, it splits up the existing integration test a little for a clearer separation of concerns. The simple file system protocol test now tests creating a file in the root volume. On this file, I test my newly created additions.Additionally,FileHandle::into_typenow returns a direct value instead of a Result. If we have a failure there, it is a hard-bug in the uefi-rs lib and not something the user should take care of.