-
-
Notifications
You must be signed in to change notification settings - Fork 170
Directory::read_entry_boxed
plus common abstraction make_boxed
#559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Directory::read_entry_boxed
plus common abstraction make_boxed
9ae56d4
to
ceefb6c
Compare
This just left it's draft state. Do you like the |
ceefb6c
to
e8171f8
Compare
8e56867
to
4ee1c21
Compare
I'm really looking forward to bumping the MSRV soon. Again, I had to alter my PR because of that 😀 @nicholasbishop @GabrielMajeri 7ce93f1 |
dfd07b3
to
c6d7297
Compare
b681a4a
to
c7a04c8
Compare
6bd7dcd
to
e1ca2c8
Compare
e1ca2c8
to
4a6a1ae
Compare
Any update here, @nicholasbishop? I need it for #472 by the way. |
Code looks good to me. One remaining thing though, |
4a6a1ae
to
12658bc
Compare
12658bc
to
7d6683a
Compare
7d6683a
to
5fdccbd
Compare
I updated the changelog and I take your words as approval. |
This adds a function to
Directory
to get directory entry information as boxed/owned values. This is done similar toFile::get_boxed_info
[commit1]. Unfortunately, the code is almost identical. I tried to create a new commonly shared abstraction [commit2]. However, it is not that easy to let it compile successfully. I'm seeking for advice.Checklist