Add PhysicalAddress/VirtualAddress to uefi-raw and use them from uefi #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
reviewed
May 4, 2023
|
|
||
| /// Physical memory address. This is always a 64-bit value, regardless | ||
| /// of target platform. | ||
| pub type PhysicalAddress = u64; |
There was a problem hiding this comment.
I'm not sure how beneficial this is.
There was a problem hiding this comment.
This typedef is part of the spec: EFI_PHYSICAL_ADDRESS
It gets used in a fair number of function definitions in the spec, so I think it's good to have.
phip1611
force-pushed
the
bishop-raw-addr-types
branch
from
efc7fa2 to
d82019d
Compare
phip1611
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist