Skip to content

Resubmission of #226 #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2021
Merged

Resubmission of #226 #261

merged 1 commit into from
Jun 12, 2021

Conversation

josephlr
Copy link
Contributor

@josephlr josephlr commented Jun 4, 2021 •
edited
Loading

#226 got messed up (see #260 (comment))

This moves the code_selector to the EntryOptions structure.

While rebasing this, I also updated the Debug implementation to
actually print out useful information instead of just hex codes.

Now an Entry when using {:#?} looks like:

Entry {
    handler_addr: 0x562341c25870,
    options: EntryOptions {
        code_selector: SegmentSelector {
            index: 6,
            rpl: Ring3,
        },
        stack_index: 5,
        type: 0b1110,
        privilege_level: Ring0,
        present: true,
    },
}

I left the type field as binary, as that's what the SDM does.

Signed-off-by: Joe Richey [email protected]

@josephlr
Resubmission of #226
c80ff08 
This moves the code_selector to the `EntryOptions` structure.

While rebasing this, I also updated the `Debug` implementation to
actually print out useful information instead of just hex codes.

I left the type field as binary, as that's what the SDM does.

Signed-off-by: Joe Richey <[email protected]>
@josephlr josephlr requested a review from phil-opp June 4, 2021 09:01
@josephlr josephlr mentioned this pull request Jun 4, 2021
Open
13 tasks
phil-opp
phil-opp approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot!

@josephlr josephlr merged commit 66952eb into next Jun 12, 2021
@josephlr josephlr deleted the idt_entry branch June 12, 2021 08:01
josephlr added a commit to josephlr/x86_64 that referenced this pull request Jul 18, 2021
@josephlr
Resubmission of rust-osdev#226 (rust-osdev#261)
288f3f9 
This moves the code_selector to the `EntryOptions` structure.

While rebasing this, I also updated the `Debug` implementation to
actually print out useful information instead of just hex codes.

I left the type field as binary, as that's what the SDM does.

Signed-off-by: Joe Richey <[email protected]>
@Freax13 Freax13 mentioned this pull request Jan 14, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephlr @phil-opp