Skip to content

CI: Run semver-checks using stable Rust #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2023
Merged

CI: Run semver-checks using stable Rust #444

merged 1 commit into from
Dec 28, 2023

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Dec 28, 2023 •
edited
Loading

Looks like the semver checks work on stable even though we're using some unstable features.

This fixes the failing semver checks CI job.

@phil-opp phil-opp marked this pull request as ready for review December 28, 2023 15:49
@phil-opp phil-opp requested a review from Freax13 December 28, 2023 15:49
Freax13
Freax13 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phil-opp
Copy link
Member Author

Thanks a lot for the quick review!

@phil-opp phil-opp merged commit 451ca2e into master Dec 28, 2023
@phil-opp phil-opp deleted the stable-semver-checks branch December 28, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freax13 Freax13 Freax13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-opp @Freax13