Use "raw-dylib" for non-win7 Windows Targets #627
Conversation
Now that we only use the standard Windows backend on Windows 1.78 or
later, we can just use `kind = "raw-dylib"` to link to
`bcryptprimitives.dll`.
This reduces the `--target=all` dependancy graph for `getrandom` to:
```
└── getrandom v0.3.1
├── cfg-if v1.0.0
├── libc v0.2.170
├── r-efi v5.2.0
└── wasi v0.14.2+wasi-0.2.4
└── wit-bindgen-rt v0.39.0
└── bitflags v2.9.0
```
Signed-off-by: Joe Richey <[email protected]>
Done, and removed the note about #593 as the dependency is now fully removed. |
### Added - `efi_rng` opt-in backend [#570] - `linux_raw` opt-in backend [#572] - `.cargo/config.toml` example in the crate-level docs [#591] - `getrandom_test_linux_without_fallback` configuration flag to test that file fallback is not triggered in the `linux_android_with_fallback` backend [#605] - Built-in support for `*-linux-none` targets [#618] - Cygwin support [#626] ### Changed - Update `wasi` dependency to v0.14 [#594] - Add `#[inline]` attribute to the inner functions [#596] - Update WASI and Emscripten links in the crate-level docs [#597] - Do not use `dlsym` on MUSL targets in the `linux_android_with_fallback` backend [#602] - Remove `linux_android.rs` and use `getrandom.rs` instead [#603] - Always use `RtlGenRandom` on Windows targets when compiling with pre-1.78 Rust [#610] - Internal representation of the `Error` type [#614] - Remove `windows-targets` dependency and use [`raw-dylib`] directly [#627] ### Removed - `Error::INTERNAL_START` and `Error::CUSTOM_START` associated constants [#614] [#570]: #570 [#572]: #572 [#591]: #591 [#594]: #594 [#596]: #596 [#597]: #597 [#602]: #602 [#603]: #603 [#605]: #605 [#610]: #610 [#614]: #614 [#618]: #618 [#626]: #626 [#627]: #627 [`raw-dylib`]: https://doc.rust-lang.org/reference/items/external-blocks.html?highlight=link#dylib-versus-raw-dylib
|
Unfortunately, there are issues with raw-dylibs before 1.84.0 on i686-pc-windows-msvc, and still to this day on i686-pc-windows-gnu. See rust-lang/rust#130586 |
|
@glandium We don't see any issues as part of our CI jobs. |
|
The issue is actually hard to reproduce in a visible way. I haven't managed to reproduce it outside the Firefox build so far. It requires several stars being aligned, the minimum of which is:
So, I'm not surprised you don't see any issues on your CI. Edit: I opened rust-lang/rust#138963 |
|
As a potential workaround we could expose the "windows legacy" backend as an opt-in backend. Would it work for you? (UPD: we technically already have the We also could modify our build.rs to account for this bug, i.e. switch to the "legacy" backend on pre-1.84 compilers and on i686 targets until the bug is fixed. But personally I would prefer to not introduce such workarounds for somewhat exotic compiler bugs (the 1.84 part is fine, but the target-dependent part is more questionable). |
Now that we only use the standard Windows backend on Windows 1.78 or later, we can just use
kind = "raw-dylib"to link tobcryptprimitives.dll.This eliminates the
windows-targetsdependency and reduces the--target=alldependancy graph forgetrandomto: