Skip to content

refactor!: use same paths representation for unix/windows #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Dec 24, 2024

Use typed_path to use a common unix path representation on both windows/unix. This will increase windows compatibility and makes testing easier.

@aawsome aawsome force-pushed the typed_path branch 2 times, most recently from dbc9dab to 32ae757 Compare December 29, 2024 14:35
@aawsome aawsome changed the title WIP: use same paths representation for unix/windows WIP: refactor!: use same paths representation for unix/windows Dec 29, 2024
@aawsome aawsome force-pushed the typed_path branch 2 times, most recently from a9d526f to af6ae1c Compare January 12, 2025 08:20
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 44.01914% with 117 lines in your changes missing coverage. Please review.

Project coverage is 43.4%. Comparing base (213665e) to head (e424290).

Files with missing lines Patch % Lines
crates/core/src/backend/local_destination.rs 0.0% 24 Missing ⚠️
crates/core/src/util.rs 35.1% 24 Missing ⚠️
crates/core/src/commands/backup.rs 33.3% 18 Missing ⚠️
crates/core/src/blob/tree.rs 46.1% 14 Missing ⚠️
crates/core/src/commands/restore.rs 0.0% 14 Missing ⚠️
crates/core/src/vfs.rs 42.8% 12 Missing ⚠️
crates/core/src/repofile/snapshotfile.rs 0.0% 3 Missing ⚠️
crates/core/src/backend/ignore.rs 80.0% 2 Missing ⚠️
crates/core/src/archiver/tree.rs 93.3% 1 Missing ⚠️
crates/core/src/backend.rs 66.6% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/archiver.rs 61.3% <100.0%> (+1.5%) ⬆️
crates/core/src/archiver/parent.rs 68.0% <100.0%> (+1.3%) ⬆️
crates/core/src/archiver/tree_archiver.rs 68.4% <100.0%> (ø)
crates/core/src/backend/childstdout.rs 75.0% <100.0%> (ø)
crates/core/src/backend/node.rs 58.9% <100.0%> (-3.1%) ⬇️
crates/core/src/repository/command_input.rs 64.0% <ø> (+2.7%) ⬆️
crates/core/tests/integration.rs 85.7% <100.0%> (+0.5%) ⬆️
crates/core/src/archiver/tree.rs 70.9% <93.3%> (+13.3%) ⬆️
crates/core/src/backend.rs 55.5% <66.6%> (ø)
crates/core/src/backend/stdin.rs 0.0% <0.0%> (ø)
... and 11 more

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aawsome aawsome force-pushed the typed_path branch 3 times, most recently from 6731779 to 626d588 Compare January 13, 2025 19:34
@aawsome aawsome changed the title WIP: refactor!: use same paths representation for unix/windows refactor!: use same paths representation for unix/windows Jan 26, 2025
@aawsome aawsome requested a review from simonsan January 26, 2025 09:40
@aawsome aawsome added the S-waiting-for-review Status: PRs waiting for review label Apr 24, 2025
@aawsome
Copy link
Member Author

aawsome commented May 23, 2025

I manually rebased to newest main.
@simonsan Can you please have a look at this PR? I think that a test on Windows is very much necessary here, but I don't own a windows system...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-for-review Status: PRs waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant