Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advisory for segmentation fault in ouch #2084

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Add advisory for segmentation fault in ouch #2084

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b38cfd9
Add advisory for segmentation fault in ouch
nyw0102 Sep 22, 2024
90ba807
Fix CI error
Shnatsel Sep 22, 2024
9db1116
Slightly more descriptive title
Shnatsel Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions crates/ouch/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "ouch"
date = "2024-09-22"
url = "https://github.com/ouch-org/ouch/issues/707"
categories = ["memory-corruption"]

[affected]
functions = { "ouch::archive::zip::convert_zip_date_time" = ["<=0.3.1"] }

[versions]
patched = [">0.3.1"]
```
# Segmentation fault due to use of uninitialized memory
When trying to decompress a file using "ouch", we can reach the function "ouch::archive::zip::convert_zip_date_time".
In the function, there is a unsafe function, "transmute". Once the "transmute" function is called to convert the type of "month" object,
the address of the object is changed to the uninitialized memory region.
After that, when other function tries to dereference "month", segmentation fault occurs.