-
Notifications
You must be signed in to change notification settings - Fork 154
Derive Debug impls #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
One thing I would suggest is to increase the version of |
7a511a3
to
218399e
Compare
Filed rustwasm/wasm-bindgen#1477 for the I'm actually not sure that this PR is a good change, since it makes the debug output more crowded while saving a couple of lines of code. |
So it's usually better to err on the side of providing more information. |
Sure, but if it's always going to print a |
It does provide value though: it lets you know that it's implemented with Also, not using |
This is now ready, methinks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Not sure this is an improvement, but hey, at least it fixes a TODO.
I also sneaked in a
Cargo.toml
change to avoid a warning.