Add env vars to filter wasm-bindgen-test-runner tests
#1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no reason for Node.js not to work in experimental-modules mode though, right? |
|
Yes when node natively supports ES modules then wasm-bindgen can just require that version of node or later when snippets are required. We don't currently export functionality to use the experimental modules because they're a moving target we haven't been able to keep up with |
Ah interesting, I was pretty sure I used them with wasm-bindgen, but I guess they were removed in the meanwhile? |
fitzgen
approved these changes
Apr 16, 2019
This is intended to handle rustwasm#1458 and rustwasm#822. These issues stem from behavior where: wasm-pack test --node will actually run both Node.js and browser tests! Two new env vars are read here, `WASM_BINDGEN_TEST_ONLY_{NODE,WEB}`, which control which tests are executed by `wasm-bindgen-test-runner`. The intention is that these will be set by `wasm-pack` to configure which tests are run, and if test suites are skipped due to the env vars we'll print an informational message indicating how they can be run. Closes rustwasm#822 Closes rustwasm#1458
alexcrichton
force-pushed
the
only-node-tests
branch
from
25b5159 to
79f370d
Compare
|
@RReverser I added support some time ago to toy around with it but it's likely regressed in the meantime and it wasn't ever really intended to be official |
alexcrichton
added a commit
to alexcrichton/wasm-pack
that referenced
this pull request
Apr 16, 2019
This builds on rustwasm/wasm-bindgen#1465 by ensuring that `wasm-pack test --node` will now only test node.js tests
alexcrichton
added a commit
to alexcrichton/wasm-pack
that referenced
this pull request
Apr 19, 2019
This builds on rustwasm/wasm-bindgen#1465 by ensuring that `wasm-pack test --node` will now only test node.js tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to handle #1458 and #822. These issues stem from
behavior where:
will actually run both Node.js and browser tests! Two new env vars are
read here,
WASM_BINDGEN_TEST_ONLY_{NODE,WEB}, which control whichtests are executed by
wasm-bindgen-test-runner. The intention is thatthese will be set by
wasm-packto configure which tests are run, andif test suites are skipped due to the env vars we'll print an
informational message indicating how they can be run.
Closes #822
Closes #1458