Skip to content

Increase interpreter buffer memory size #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2022
Merged

Increase interpreter buffer memory size #3162

merged 2 commits into from
Nov 26, 2022

Conversation

mvolfik
Copy link
Contributor

@mvolfik mvolfik commented Nov 22, 2022

Long typescript types don't fit into the buffer, causing stack pointer to underflow and wrap to numbers around usize::MAX

Fixes #2846

Liamolucko
Liamolucko approved these changes Nov 26, 2022
View reviewed changes
Copy link
Collaborator

@Liamolucko Liamolucko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable enough to me. Thanks!

@Liamolucko Liamolucko merged commit f0b154e into rustwasm:main Nov 26, 2022
@daxpedda daxpedda mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liamolucko Liamolucko Liamolucko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long typescript_type leads to compile error in debug mode
2 participants
@mvolfik @Liamolucko