Expose WebAssembly.Instance.exports
#3296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was specifically attempting to use #3177 but noticed it was impossible to call
__wbindgen_thread_destroy()
or get__tls_base
and__stack_alloc
from inside Rust.Alternatively we could exposeWebAssembly.Instance.prototype.exports
directly instead.EDIT: I decided to go ahead and expose the exports directly. Mainly because there were some targets that were much harder for me to implement exposing the instance for.
Or if we don't want a general-purpose solution like this we could expose
__wbindgen_thread_destroy()
,__tls_base
and__stack_alloc
through more intrinsics.I'm not aware of any downsides.
EDIT: I was thinking that maybe exposing exports directly is worse then exposing the instance, but it seems that you can't do anything else with the instance anyway: https://developer.mozilla.org/en-US/docs/WebAssembly/JavaScript_interface/Instance.
Fixes #2513.