Skip to content

Use isLikeNone to detect null/undefined for string enums #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2024
Merged

Use isLikeNone to detect null/undefined for string enums #4186

merged 3 commits into from
Oct 12, 2024

Conversation

RunDevelopment
Copy link
Contributor

This is a very minor thing I noticed. All conversions except the string enum one use isLikeNone to detect none-like JS values (undefined and null). So I change the JS string enum to WASM string enum conversion to use isLikeNone as well. All conversions new use isLikeNone to detect none-like values.

daxpedda
daxpedda approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@daxpedda daxpedda merged commit 61f1d96 into rustwasm:main Oct 12, 2024
41 checks passed
@RunDevelopment RunDevelopment deleted the islikenone branch October 12, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @daxpedda