Skip to content

Fix binaryen toolchain URL #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix binaryen toolchain URL #1163

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1aeb4b
Fix binaryen toolchain URL
matheus23 Aug 11, 2022
7fddcca
Make x86 32bit an unsupported installation target
matheus23 Aug 17, 2022
2874ace
Fix macos install target path
matheus23 Aug 17, 2022
9a4e9ee
Fix windows x86_64 binaryen toolchain download URL
matheus23 Aug 23, 2022
3bd37c9
Test URL-building matrix
matheus23 Aug 23, 2022
ddb4084
Apply patches from @printfn
matheus23 Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/install/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ pub fn download_prebuilt(
fn prebuilt_url(tool: &Tool, version: &str) -> Result<String, failure::Error> {
let target = if target::LINUX && target::x86_64 {
match tool {
Tool::WasmOpt => "x86-linux",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This previously matched what target::x86 fetches

Is 32 bit x86 no longer packaged? ie does the else if after this block fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can only see x86_64 in the binaryen releases: https://github.com/WebAssembly/binaryen/releases/tag/version_108

Tool::WasmOpt => "x86_64-linux",
_ => "x86_64-unknown-linux-musl",
}
} else if target::LINUX && target::x86 {
Expand Down