Import ComponentClass and Component #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both ComponentClass and Component should be imported from `react`. `react-redux` doesn't contain those two.
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 6 6
Lines 245 245
Branches 73 73
=======================================
Hits 234 234
Misses 10 10
Partials 1 1Continue to review full report at Codecov.
|
ryandrewjohnson
approved these changes
Jul 12, 2018
|
Thanks for the fix 👍 |
ryandrewjohnson
pushed a commit
that referenced
this pull request
Jul 13, 2018
Both ComponentClass and Component should be imported from `react`. `react-redux` doesn't contain those two.
ryandrewjohnson
added a commit
that referenced
this pull request
Jul 14, 2018
…issing translation fallbacks (#110) * setting up getOptions to return the first lagnuage available as default if a default language isn't provided * set up the missing translation callback to localize the translation before passing it as a value * prettier and fixing some flow issues with onMissingTranslation fixes * Import ComponentClass and Component (#106) Both ComponentClass and Component should be imported from `react`. `react-redux` doesn't contain those two. * update CHANGELOG * 3.2.2 * move onMissingTranslation logic from getLocalizedElement to getTranslate * fix flow issues * remove uneeded import from TS definition * add missing default translation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both ComponentClass and Component should be imported from
react.react-reduxdoesn't contain those two.