Don't import cysignals.alarm on Windows #39010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit f6add4e; changes) is ready! 🎉 |
dimpase
approved these changes
May 15, 2025
|
Thanks, and yes - I guess it's mainly there for backwards compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cysignals.alarmis not available on Windows, so we don't try to import it. Probably more work needs to be done to actually fix the methods that make use of these methods on Windows; but that's left for further PRs.Also remove a
cysignalsimport from anall_xyz.pyfile that was duplicated in the mainall.pyfile.📝 Checklist
⌛ Dependencies