Add script for checking for old deprecations #39262

tobiasdiez · 2025-01-04T09:53:49Z

To find deprecations that can now safely removed.
Example:

python tools/check_deprecations.py src/sage/combinat
Found 9 deprecations.
100%|
Deprecations over one year ago:
File: src\sage\combinat\permutation.py, PR: https://github.com/sagemath/sage/pull/26810, Closed Date: 2019-01-23
File: src\sage\combinat\permutation.py, PR: https://github.com/sagemath/sage/pull/27467, Closed Date: 2019-06-12
File: src\sage\combinat\words\finite_word.py, PR: https://github.com/sagemath/sage/pull/30187, Closed Date: 2020-09-15
File: src\sage\combinat\designs\difference_family.py, PR: https://github.com/sagemath/sage/pull/35211, Closed Date: 2023-04-01

📝 Checklist

The title is concise and informative.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation and checked the documentation preview.

⌛ Dependencies

github-actions · 2025-01-04T10:37:22Z

Documentation preview for this PR (built with commit a89744a; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

fchapoton · 2025-01-19T10:27:23Z

interesting. But the delay is one year after the first stable release including the deprecation.

fchapoton · 2025-02-05T11:09:59Z

Trying that, I installed pygithub using sage-pip install pygithub.
But I could only run once before hitting the "rate limit exceeded" message. And now everything is blocked for several thousand seconds, it seems. Otherwise, pretty useful

to make copy-pasting more easy

tobiasdiez · 2025-02-06T19:30:29Z

Trying that, I installed pygithub using sage-pip install pygithub. But I could only run once before hitting the "rate limit exceeded" message. And now everything is blocked for several thousand seconds, it seems. Otherwise, pretty useful

Yes, the rate limit is rather low but nothing we can change. Creating a personal API key is also rather straightforward.

So you are happy with this PR? Or should we change the limit to say 15 months to account for the fact that the PR is merged some time before the actual release?

sagemathgh-39461: remove old deprecation in modular symbols found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39461 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

sagemathgh-39462: remove a deprecation simplicial complexes found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39462 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton

sagemathgh-39463: remove deprecated stuff in cremona_database found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39463 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39465 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

sagemathgh-39461: remove old deprecation in modular symbols found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39461 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

sagemathgh-39462: remove a deprecation simplicial complexes found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39462 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton

sagemathgh-39463: remove deprecated stuff in cremona_database found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39463 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

sagemathgh-39465: remove deprecated stuff in polyhedron plot found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39465 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

sagemathgh-39461: remove old deprecation in modular symbols found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39461 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

sagemathgh-39462: remove a deprecation simplicial complexes found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39462 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton

sagemathgh-39463: remove deprecated stuff in cremona_database found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39463 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

sagemathgh-39465: remove deprecated stuff in polyhedron plot found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39465 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

sagemathgh-39454: remove deprecated stuff in permutation.py found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39454 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw

sagemathgh-39466: remove some deprecations in groups found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39466 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

sagemathgh-39464: remove deprecated method in normal_form_game found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39464 Reported by: Frédéric Chapoton Reviewer(s): David Coudert

tools/README.md

tools/check_deprecations.py

Co-authored-by: Frédéric Chapoton <[email protected]>

tobiasdiez · 2025-04-15T08:07:58Z

@fchapoton can we please get this in?

fchapoton · 2025-05-14T12:41:52Z

the two "meson" changes are not related, right ?

tobiasdiez · 2025-05-14T13:55:55Z

The change in pyproject.toml ensures that one can install the required dependencies for this script via the dev group. The change in update-meson is indeed only for consistency and adds inline dependency info (so you can run the script via uv and it will automatically install the correct deps).

fchapoton

ok, let's move on

tobiasdiez · 2025-05-14T15:28:14Z

Thanks!

Add script for checking for old deprecations

652e77e

github-actions bot added the s: needs review label Jan 4, 2025

Merge branch 'develop' into check-depr

76d5ef4

tobiasdiez requested review from kwankyu, fchapoton and dcoudert January 19, 2025 09:26

fchapoton mentioned this pull request Feb 5, 2025

remove deprecated stuff in permutation.py #39454

Merged

2 tasks

detail in check_deprecations.py

830fe68

to make copy-pasting more easy

fchapoton mentioned this pull request Feb 6, 2025

remove some deprecations in groups #39466

Merged

2 tasks

Merge remote-tracking branch 'upstream/develop' into check-depr

a387e86

tobiasdiez and others added 3 commits February 28, 2025 15:45

Merge branch 'develop' into check-depr

a890b59

Merge branch 'develop' into check-depr

4bec7fb

Merge remote-tracking branch 'upstream/develop' into check-depr

db1826d

fchapoton reviewed Mar 15, 2025

View reviewed changes

tools/README.md Outdated Show resolved Hide resolved

fchapoton reviewed Mar 15, 2025

View reviewed changes

tools/check_deprecations.py Outdated Show resolved Hide resolved

tobiasdiez and others added 2 commits March 20, 2025 05:10

Apply suggestions from code review

30ed57b

Co-authored-by: Frédéric Chapoton <[email protected]>

Merge branch 'develop' into check-depr

54ae2da

Merge branch 'develop' into check-depr

a89744a

fchapoton added the c: scripts label May 14, 2025

fchapoton approved these changes May 14, 2025

View reviewed changes

fchapoton added s: positive review and removed s: needs review labels May 14, 2025

vbraun merged commit 9de6bc0 into sagemath:develop May 18, 2025
22 of 23 checks passed

github-actions bot removed the s: positive review label May 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add script for checking for old deprecations #39262

Add script for checking for old deprecations #39262

Uh oh!

tobiasdiez commented Jan 4, 2025

Uh oh!

github-actions bot commented Jan 4, 2025 •

edited

Loading

Uh oh!

fchapoton commented Jan 19, 2025

Uh oh!

fchapoton commented Feb 5, 2025

Uh oh!

tobiasdiez commented Feb 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

tobiasdiez commented Apr 15, 2025

Uh oh!

fchapoton commented May 14, 2025

Uh oh!

tobiasdiez commented May 14, 2025

Uh oh!

fchapoton left a comment

Uh oh!

tobiasdiez commented May 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add script for checking for old deprecations #39262

Add script for checking for old deprecations #39262

Uh oh!

Conversation

tobiasdiez commented Jan 4, 2025

📝 Checklist

⌛ Dependencies

Uh oh!

github-actions bot commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fchapoton commented Jan 19, 2025

Uh oh!

fchapoton commented Feb 5, 2025

Uh oh!

tobiasdiez commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tobiasdiez commented Apr 15, 2025

Uh oh!

fchapoton commented May 14, 2025

Uh oh!

tobiasdiez commented May 14, 2025

Uh oh!

fchapoton left a comment

Choose a reason for hiding this comment

Uh oh!

tobiasdiez commented May 14, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2025 •

edited

Loading

tobiasdiez commented Feb 6, 2025 •

edited

Loading