-
-
Notifications
You must be signed in to change notification settings - Fork 618
move finite field methods #39532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move finite field methods #39532
Conversation
Documentation preview for this PR (built with commit 2d80c18; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now looks good. I have committed my own small suggestion. Good to go
I am currently sick, but it seems to me that we haven't found a good solution to the problem with cellularbasis.one yet. |
OK, so is there anything left to be done here? |
well, the continuous integration seems to be very broken right now. So maybe one needs to run the full tests ourselves.. |
I'm doing that now, on ubuntu. |
On Ubuntu 24.04.2 LTS all tests pass, except for two expected FriCAS failures. |
So, the only question is whether we are doing the right thing here, design-wise. I cannot judge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is moving in the right direction, so positive review.
📝 Checklist
⌛ Dependencies