Skip to content

issue#95&#108 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

issue#95&#108 #6

merged 1 commit into from
Jun 27, 2023

Conversation

saicheck2233
Copy link
Owner

Issue#95 & Issue#108: Validation passed even though required field is empty

Description: Field is required and it is empty but then validation still shows succeeded for the JSON schema below

{
	"title": "Person",
	"type": "object",
	"properties": {
		"firstName": {
			"type": "string"
		},
		"lastName": {
			"type": "string"
		},
		"age": {
			"description": "Age in years",
			"type": "integer",
			"minimum": 0
		}
	},
	"required": [
		"firstName",
		"lastName"
	]
}

Pic before changes:
image
The validation passed eventhough the field firstName and lastName are required

Pic after changes:
image
The validation did not pass as the field firstName and lastName are required and cannot be empty

@saicheck2233 saicheck2233 merged commit ba4f9ed into master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants