test(locale): improve test using locale en_US.UTF-8

[myii]

• Configure locale on Debian-based instances and CentOS-7

---

Continues work done in #262, where the locales were commented out at the time.

[n-rodriguez]

@myii : good work 👍

but I have one question : can the locales be set in the docker image instead?

[vutny]

In modern Debian distros and derivatives, the locale-gen just reads /etc/locale.gen file, and simply ignores locale as and argument. Despite what the manpage tells you :) So it is superfluous.

When I want to test l11n and i18n within my images I usually rely on explicitly setting the locales package configuration via debconf. That mitigates any weird hacks were done in the underlying image by someone else. Using these commands:

echo 'locales locales/locales_to_be_generated multiselect en_US.UTF-8 UTF-8, en_GB.UTF-8 UTF-8' | sudo debconf-set-selections -
echo 'locales locales/default_environment_locale select en_US.UTF-8' | sudo debconf-set-selections -
sudo dpkg-reconfigure -f noninteractive locales

This is rather a suggestion, not a mandatory thing.

[myii]

@vutny Thanks for the feedback. I've tried it out on a separate branch but I'm hitting the same error on all of the Debian-based instances:

       *** update-locale: Error: invalid locale settings:  LANG=en_US.UTF-8
       The command '/bin/sh -c sudo dpkg-reconfigure -f noninteractive locales' returned a non-zero code: 255

Full logs available here: https://travis-ci.com/myii/postgres-formula/builds/111870004.

---

In any case, we've discussed this on Slack and @javierbertoli may be able to ensure that we don't need this process at all. en_US.UTF-8 is already configured on most of the images, except for debian-8 and debian-9. If those can be resolved, we can remove all of the provision_command sections from this PR.

[vutny]

@vutny Thanks for the feedback. I've tried it out on a separate branch but I'm hitting the same error on all of the Debian-based instances:

Ah, of course! Forgot the very first command 😄

sudo rm -f /etc/default/locale /etc/locale.gen

In any case, we've discussed this on Slack and @javierbertoli may be able to ensure that we don't need this process at all. en_US.UTF-8 is already configured on most of the images, except for debian-8 and debian-9. If those can be resolved, we can remove all of the provision_command sections from this PR.

Yeah, sure. This is the best option. Better to put those commands into Dockerfile.

[myii]

@vutny Yes, that worked: https://travis-ci.com/myii/postgres-formula/builds/111883527. Let's see what the final outcome is for en_US.UTF-8.

[myii]

Thanks to @javierbertoli, all of the pre-salted images are configured with the en_US.UTF-8 locale. So all of the provision_commands have been removed.

I've also added a couple of further changes based on the template-formula. The first one is to remove the temporary suse conditional since that's been fixed upstream (thanks @n-rodriguez!). The second is to reduce the testing matrix back to the "tree"-shaped matrix. I did test these changes before reducing the matrix and all was OK:

• https://travis-ci.com/myii/postgres-formula/builds/113817072

@vutny If you are good with the changes, would you mind merging this?

[vutny]

Thanks @myii , great work!
I guess you need to throw away changes in .travis.yml, as I see all defined instances have been passed in your other branch covered by Travis.

[myii]

Thanks @myii , great work!
I guess you need to throw away changes in .travis.yml, as I see all defined instances have been passed in your other branch covered by Travis.

@vutny It's a bit ugly but we've been leaving them there (commented out) to make it easier when diffing with the template-formula (across numerous formulas). It's especially helpful when there are multiple changes to propagate, as there already have been with .travis.yml. And there are still more changes expected, since we're evaluating other CI solutions. So I'd appreciate it if we can keep hold of them there, for easier multi-formula maintenance.

[vutny]

@myii Okay, got you.
And I hope this would be really temporary thing, since we have the full test suit working here, so be able to catch any regressions.

[myii]

@vutny Sorry, I didn't get your angle about the "temporary thing". Do you mean in terms of having all of the instances running again? Or do you mean removing the commented lines? In any case, if anyone wants to help stabilise the CI setup, that would be greatly appreciated. Here's a bit more background for interested parties, even if only to offer comment: saltstack-formulas/template-formula#118.

I'll go ahead and merge this in the meanwhile, thanks for the review.

[saltstack-formulas-travis]

🎉 This PR is included in version 0.37.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀