Skip to content

Run CI on PRs / fix tests #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2024
Merged

Run CI on PRs / fix tests #131

merged 2 commits into from
May 18, 2024

Conversation

davidfischer
Copy link
Member

@davidfischer davidfischer commented May 16, 2024

The CI wasn't run on a PR where the branch was in a fork. This fixes that issue and runs the formatter across the new code from #130.

The CI wasn't run on a PR where the branch was in a fork.
This fixes that issue and runs the formatter across the new code.
@davidfischer davidfischer changed the title Run CI on PRs Run CI on PRs / fix tests May 16, 2024
Copy link
Contributor

@jlgimeno jlgimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a deprecation warning from Github Actions for node.js, which we can safely take care of some day. LGTM!

@davidfischer davidfischer merged commit 218fd4b into main May 18, 2024
1 check passed
@davidfischer davidfischer deleted the davidfischer/run-ci-on-prs branch May 18, 2024 18:02
@davidfischer
Copy link
Member Author

I see a deprecation warning from Github Actions for node.js, which we can safely take care of some day

What warning is that? Also I wonder if we can greatly reduce our use of node and webpack generally by switching to something like Tailwind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants